nelfin / pylint-protobuf

A plugin for making Pylint aware of the fields of protobuf-generated classes
MIT License
29 stars 12 forks source link

pylint 3.0.0 compatibility #57

Closed matejsp closed 1 year ago

matejsp commented 1 year ago

This project is no longer working with pylint 3.0.0

Cireo commented 1 year ago

According to the pylint maintainer the fix should just be

It's as simple as just removing the code in question. It never worked; it was always just cruft.

dropping those lines.

nelfin commented 1 year ago

Sorry about the wait, thanks for the heads up. I've pushed a change to remove the reference to those obsoleted interfaces, try installing the pre-release via pip install git+https://github.com/nelfin/pylint-protobuf@ee09677a8f800cbab789a01438e8a0066d179c67. Try that and see how you go.

matejsp commented 1 year ago

Sorry it does not work for me.

It complains about missing import: https://github.com/nelfin/pylint-protobuf/blob/fix/57-pylint-v3/pylint_protobuf/__init__.py#L6

after removing the import, I get error in:

@utils.check_messages('protobuf-enum-value')

changed to (couple of them according to pylint release notes):

@utils.only_required_for_messages('protobuf-enum-value')

After all those changes it does not crash (but didn't really test it but it does not crash anymore). I didn't prepare PR since I don't know if you want to preserve backwards compatibility or not.

nelfin commented 1 year ago

-_-" I don't have a working dev environment at the moment so I missed that. I've fixed the broken import and added a compat shim for the removal of check_messages (since I would like to keep compatibility with pylint 2 for at least a little while). Try pip install git+https://github.com/nelfin/pylint-protobuf@fb8a8887c2f67cf74b3a653d1093d4609dafbcf1

matejsp commented 1 year ago

It's perfect, no more errors :) can't wait for the official release 🥇

nelfin commented 1 year ago

@matejsp This has been released as v0.21.0 just now. Invoke python -m pip install -U pylint-protobuf to install the latest release

matejsp commented 1 year ago

I have installed 0.21.0 from pypi and it is working for me.

Just missing merge to master and git tag/release on github :D

Cireo commented 1 year ago

Thanks for the prompt fixes @nelfin 🙇 appreciate the project