nelhage / gojit

JIT code-generation in Go!
MIT License
338 stars 34 forks source link

Upgraded to be dependent on mmap-go for cross-platform support #7

Closed JamesDunne closed 9 years ago

JamesDunne commented 9 years ago

Passes tests on windows/amd64.

nelhage commented 9 years ago

Thanks! Of course, in testing this I have discovered that tests don't work at all on 1.4, and I'm not sure it can be fixed, but oh well :)

JamesDunne commented 9 years ago

Yeah I ran the full test suite including the assembler stuff and found a bunch of failures lol. Seems recursion is broken and calling the GC from JITted code is broken. They seem to have changed the stack layout in 1.4 somehow.

nelhage commented 9 years ago

Yeah, I've got a fix on the go1.4 branch, but need to fix it to compile on 1.3, too :) On Mar 25, 2015 1:44 PM, "James Dunne" notifications@github.com wrote:

Yeah I ran the full test suite including the assembler stuff and found a bunch of failures lol. Seems recursion is broken and calling the GC from JITted code is broken. They seem to have changed the stack layout in 1.4 somehow.

— Reply to this email directly or view it on GitHub https://github.com/nelhage/gojit/pull/7#issuecomment-86031580.