nelhage / llama

Apache License 2.0
584 stars 24 forks source link

Support explicit negative values for environment variables. #41

Closed jpeach closed 3 years ago

jpeach commented 3 years ago

It's easy to forget that setting the LLAMACC environment variables to any value enables the corresponding setting. Add support for explicitly setting them to negative values to also disable the corresponding setting.

This bit me a few times when I set LLAMACC_FULL_PREPROCESS=0 and could not figure out what I had done wrong :joy:

nelhage commented 3 years ago

Nice, I like it. I definitely idly thought about this when first adding config flags but then shrugged it off…