nelhage / reptyr

Reparent a running program to a new terminal
MIT License
5.71k stars 216 forks source link

FreeBSD: Fix tty stealing, enable at least that test #114

Closed kevans91 closed 4 years ago

kevans91 commented 4 years ago

As described in the commit messages, we actively haven't implemented TIOCNOTTY in at least 17 years. I have an implementation WIP, but it will be a while before this becomes usable from a CI standpoint. =-(

The tty-stealing test uncovered a bug in my implementation where I didn't actually make sure the master fds we were gathering corresponded to the victim (d'oh!). Easily fixed- do that, and now the tests pass and the implementation is more correct than my initial testing!

Thanks again for this fine piece of software. =)

nelhage commented 4 years ago

Amazing!