Response listener gets added multiple times in a ReactPHP environment

nelmio / NelmioCorsBundle

Adds CORS (Cross-Origin Resource Sharing) headers support in your Symfony application

https://symfony.com/bundles/NelmioCorsBundle/

MIT License

1.89k stars 108 forks source link

Response listener gets added multiple times in a ReactPHP environment #114

Closed acasademont closed 1 year ago

acasademont commented 5 years ago

Right now the listener assumes the EventDispatcher will be rebooted after every request as per the normal PHP way of handling requests, not the case in a ReactPHP app, where all services are long-lived and serve many requests. Therefore, on every CORS request, the response listener is added again to the EventDispatcher queue. Not sure if there's an easy way to prevent that without a considerable refactor.

Seldaek commented 1 year ago

This was fixed.. some time ago :D