search

nelmio / NelmioCorsBundle

Adds CORS (Cross-Origin Resource Sharing) headers support in your Symfony application
https://symfony.com/bundles/NelmioCorsBundle/
MIT License
1.89k stars 108 forks source link

Deprecated: A tree builder without a root node is deprecated since Symfony 4.2 and will not be supported anymore in 5.0. #116

Closed cydrickn closed 5 years ago

cydrickn commented 5 years ago

Fix the deprecation in Symfyny 4.2

use 

<?php

namespace Nelmio\CorsBundle\DependencyInjection;

...

class Configuration implements ConfigurationInterface
 {
    /**
     * {@inheritDoc}
     */
    public function getConfigTreeBuilder()
    {
        if (method_exists(TreeBuilder::class, 'getRootNode')) {
            $treeBuilder = new TreeBuilder('nelmio_cors');
            $rootNode = $treeBuilder->getRootNode();
        } else {
            $treeBuilder = new TreeBuilder();
            $rootNode = $treeBuilder->root('nelmio_cors');
        }
        ...
    }
    ....
}

I can make PR for this.

raress96 commented 5 years ago

Is it possible to create a new tag/version for Symfony 4.2?