nelmio / NelmioCorsBundle

Adds CORS (Cross-Origin Resource Sharing) headers support in your Symfony application
https://symfony.com/bundles/NelmioCorsBundle/
MIT License
1.89k stars 108 forks source link

Support for Symfony 5 #136

Closed GwendolenLynch closed 4 years ago

GwendolenLynch commented 5 years ago

This is probably going to need a few changes based on feedback. I just thought I'd get it all together & testable first.

~There are two related upstream PRs for SymfonyTest https://github.com/SymfonyTest/SymfonyDependencyInjectionTest/pull/121 and https://github.com/SymfonyTest/SymfonyConfigTest/pull/63 to make the DI test package work.~

~That is where part of the version bump(s) come in. The package has a BC break in signatures after v3, and v4 requires PHPUnit 8 for TestCase compatibility.~

So please let me know what more is wanted, or not, and I'll happily work to get this over the line :smiley_cat:

Summary

fabpot commented 4 years ago

As this bundle is used by API Platform... ans because I want to write a chapter on API Platform in my upcoming Symfony book... that should be finished really soon now, I would appreciate a version of this bundle that supports Symfony 5 :)

GwendolenLynch commented 4 years ago

@nicolas-grekas I've pushed a change that drops the test library & bumps PHP requirements on Travis down to 7.1 :tada:

Seldaek commented 4 years ago

Seems fine to me, all good to merge then or did you wanna do more @GawainLynch ?

GwendolenLynch commented 4 years ago

I'd say :shipit:, thank you @Seldaek :+1:

Seldaek commented 4 years ago

Thank you for the work