rework forced_allow_origin_value option to always set the header

nelmio / NelmioCorsBundle

Adds CORS (Cross-Origin Resource Sharing) headers support in your Symfony application

https://symfony.com/bundles/NelmioCorsBundle/

MIT License

1.89k stars 108 forks source link

rework forced_allow_origin_value option to always set the header #72

Closed Oliboy50 closed 7 years ago

Oliboy50 commented 7 years ago

Fix #66 (cache issues)

Because the forced_allow_origin_value option is only useful for the cache issues... but it doesn't solve it yet.

Note: As @Seldaek said, we could also set a Vary: Origin header to workaround the cache issues instead of merging this PR (if the cache system supports it).

Oliboy50 commented 7 years ago

@Seldaek I updated the PR, now it won't change anything for those who don't use the forced_allow_origin_value option. Could be a v1.5.1 don't you think so? 😄

Seldaek commented 7 years ago

Thanks, 1.5.1 is out https://github.com/nelmio/NelmioCorsBundle/releases