search

nelmio / NelmioSecurityBundle

Adds extra security-related features in your Symfony application
https://symfony.com/bundles/NelmioSecurityBundle/
MIT License
651 stars 85 forks source link

Bump PHPStan level to 8 #282

Closed franmomu closed 2 years ago

franmomu commented 2 years ago

With level 8 I think we are fine with the static analysis.

The ignored errors added are about InputBag::get() call returning null after calling :InputBag:has(), issue related to https://github.com/phpstan/phpstan-symfony/pull/250.

codecov-commenter commented 2 years ago

Codecov Report

Merging #282 (e25a545) into master (7fd80cb) will decrease coverage by 0.30%. The diff coverage is 58.82%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #282      +/-   ##
============================================
- Coverage     90.81%   90.51%   -0.31%     
- Complexity      443      449       +6     
============================================
  Files            44       44              
  Lines          1317     1328      +11     
============================================
+ Hits           1196     1202       +6     
- Misses          121      126       +5
Impacted Files Coverage Δ
...licy/Violation/Filter/CustomRulesNoiseDetector.php 0.00% <0.00%> (ø)
src/EventListener/ExternalRedirectListener.php 90.74% <ø> (ø)
src/Session/CookieSessionHandler.php 65.43% <ø> (ø)
...stener/AbstractContentTypeRestrictableListener.php 90.00% <50.00%> (-10.00%) :arrow_down:
src/EventListener/FlexibleSslListener.php 87.14% <50.00%> (-3.49%) :arrow_down:
src/ContentSecurityPolicy/PolicyManager.php 95.23% <75.00%> (-2.20%) :arrow_down:
...rc/DependencyInjection/NelmioSecurityExtension.php 89.81% <100.00%> (ø)
...ExternalRedirect/WhitelistBasedTargetValidator.php 94.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7fd80cb...e25a545. Read the comment docs.