search

nelmio / NelmioSecurityBundle

Adds extra security-related features in your Symfony application
https://symfony.com/bundles/NelmioSecurityBundle/
MIT License
651 stars 85 forks source link

Mark FlexibleSslListener::logout() as internal #299

Closed franmomu closed 2 years ago

franmomu commented 2 years ago

This way we can remove the method when dropping support for Symfony 4.4.

I was thinking about if listeners in general should be internal since the user shouldn't interact with them directly 🤔

codecov-commenter commented 2 years ago

Codecov Report

Merging #299 (11278e4) into master (7fefe93) will increase coverage by 0.33%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #299      +/-   ##
============================================
+ Coverage     93.21%   93.55%   +0.33%     
  Complexity      452      452              
============================================
  Files            57       57              
  Lines          1489     1489              
============================================
+ Hits           1388     1393       +5     
+ Misses          101       96       -5
Impacted Files Coverage Δ
src/EventListener/FlexibleSslListener.php 94.28% <ø> (+7.14%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7fefe93...11278e4. Read the comment docs.