search

nelmio / alice

Expressive fixtures generator
MIT License
2.49k stars 330 forks source link

Fix deprecations #1157

Closed jderusse closed 9 months ago

jderusse commented 9 months ago

This PR fixes the below deprecations:

Deprecated: Optional parameter $resolver declared before required parameter $context is implicitly treated as a required parameter in /srv/api/vendor/nelmio/alice/src/Generator/Resolver/Parameter/Chainable/StringParameterResolver.php on line 91

Deprecated: Optional parameter $flags declared before required parameter $value is implicitly treated as a required parameter in /srv/api/vendor/nelmio/alice/src/FixtureBuilder/Denormalizer/Fixture/SpecificationBagDenormalizer/Value/UniqueValueDenormalizer.php on line 47

Deprecated: Optional parameter $flags declared before required parameter $value is implicitly treated as a required parameter in /srv/api/vendor/nelmio/alice/src/FixtureBuilder/Denormalizer/Fixture/SpecificationBagDenormalizer/ValueDenormalizerInterface.php on line 33

Deprecated: Optional parameter $flags declared before required parameter $value is implicitly treated as a required parameter in /srv/api/vendor/nelmio/alice/src/FixtureBuilder/Denormalizer/Fixture/SpecificationBagDenormalizer/Value/SimpleValueDenormalizer.php on line 40

note: This can't be a BC break as the parameter is required (see the PHP deprecation message, and also POC )

theofidry commented 9 months ago

Thank you @jderusse