nelsam / vidar

vidar is a highly experimental Go editor, written in Go, using gxui
The Unlicense
50 stars 7 forks source link

Override AddPanelAt in TabbedEditor #108

Closed nelsam closed 6 years ago

nelsam commented 6 years ago

Dragging panels between tabbed editors was causing the new tabbed editor to add the panel as a child without also storing that editor in its map of available editors. This meant that the next time something tried to focus the editor, it would open a second copy of that tab.

This fixes that issue.

Resolves #107

Type

Tests

I have tested locally against:

I have included automated tests:

nelsam commented 6 years ago

@Kvaz1r this should solve #107 - could you build from this branch (107-duplicate-tabs) and see if it solves the issue for you?

Kvaz1r commented 6 years ago

yes, it's works for me.

nelsam commented 6 years ago

Cool. I'll merge after travis gets around to running the build.