plugin/gocode: actually close when there are no results to apply - Githubissues

nelsam / vidar

vidar is a highly experimental Go editor, written in Go, using gxui

The Unlicense

50 stars 7 forks source link

plugin/gocode: actually close when there are no results to apply #141

Closed nelsam closed 6 years ago

nelsam commented 6 years ago

Prior to this, there were cases where gocode would have an empty list and try to apply a nonexistent code suggestion. We've prevented these types of issues from crashing the editor, but we didn't fix the plugin (partly because we wanted to use the plugin to verify the fixes in the editor). These are now fixed.

Type

[x] Bug Fix
[ ] New Feature
[ ] Quality of Life Improvement

Tests

I have tested locally against:

[ ] Windows
[x] linux
[ ] OS X
[ ] BSD

I have included automated tests:

[ ] Unit tests
[ ] Integration tests
[ ] End to end tests