nelsam / vidar

vidar is a highly experimental Go editor, written in Go, using gxui
The Unlicense
50 stars 7 forks source link

Add handlers for suggestions #144

Closed Kvaz1r closed 5 years ago

Kvaz1r commented 6 years ago

For #119

Suggestion list has controlled by editor events(Confirm after Enter and Cancel after escape) so it also needs handlers for list itself. I use driver.CallSync/1 since without it periodically get

panic: AssertUIGoroutine called on a go-routine that was not the UI go-routine

but I don't sure is it correct.

Type

Tests

I have tested locally against:

I have included automated tests:

nelsam commented 5 years ago

I'm working on a rewrite of a bunch of the code in vidar to help us rely on gxui a little less and make the core logic a bit more task-specific. I'm merging this as-is so that we don't have a messy rebase later. However, I left some comments that I'll want to address at a later date.