nelsam / vidar

vidar is a highly experimental Go editor, written in Go, using gxui
The Unlicense
50 stars 7 forks source link

Change margin for linenumber #159

Closed Kvaz1r closed 5 years ago

Kvaz1r commented 5 years ago

Using non-defaults fonts doesn't show whole label for some reason. If change margin for label from 3(default label value) to 0 this behaviour change. Default font also keeps look good.

Before : before After : after

But I don't see any reason keep use this overloading and would prefer apply this change to base class in mixins since there aren't any significant differences.

Type

Tests

I have tested locally against:

I have included automated tests:

nelsam commented 5 years ago

I have no idea why the first test run failed; this looks good to me.