Closed abakermi closed 8 months ago
Hi @abakermi thanks for creating this PR. 🙌 You have done a good job of moving the code toward better modularity/maintainability. 👍 Curious why Travis-CI https://travis-ci.org/github/nelsonic/github-scraper is not passing ... 💭 Might need to update a couple of the tests/assertions. 💡
hi @nelsonic ,Travis-CI won't pass unless we update the rest of tests, I just update repo/repos
Looks like it's only one test: https://travis-ci.org/github/nelsonic/github-scraper/builds/711131428#L613
Note: I definitely would not normally tell anyone to comment out tests, but in this case it's "OK" because the underlying UI has changed so the tests will continue to fail until the selector is updated.
Please comment out the line: https://github.com/nelsonic/github-scraper/blob/47d0a460db49b5ea3067ce4eb1d4e6bc27b7f505/test/followers.test.js#L7
And see if the rest of the tests pass. Thanks. ☀️
I suspect thats one test failt , anyway i will update the rest of the test and push again .
Thanks! 👍 Out of curiosity: how did you find this repo? (what did you search for?) 🔍 And how are you hiding stats on your GitHub profile? 🚫 (is that a new option they have added recently?)
hhh I don't hide my stats, just I don't have time to contribute, and for repos I see issuehub.io
I mean these "profile" stats ... this is what I see: (no stars or follower count) 🤷♂️
But I just checked in incognito mode and they are visible. 👍 GitHub must be A-B testing on me 🙄
Thanks for sharing the link to http://issuehub.io 🔗
113 fix repo/repos ui updates