Closed Jonii closed 4 months ago
@Jonii if you still have time to help with this it would be awesome. 🙏 If not I can try and continue your work. 👌
I am not currently able to work on this. I forgot much of the context already, but I know I didn't expect to see merge conflicts pop up. Well, except for a bit of code I removed, as it was not covered by real tests re: its functionality. I could've added tests for it, but since the theme was to make existing tests pass, I focused on that. There wasn't supposed to be work left, except perhaps adding tests for the removed functionality that would then justify re-adding the feature.
I might be able to look at this more carefully in a few days or weeks. But, in case it helps, conflicts were not supposed to be there, so something's gone oopsie, and I don't yet know what's the error.
@Jonii thanks. The merge-conflicts
are due to a few updates we've made.
If you rebase on main
branch and see what still needs to be updated. 💭
Closing as this branch has diverged too far from main
and will take too much effort to rebase. ⏳
Feel free to re-open if you think you'll have time to rebase. 👌
Profile_contribs.js removed as it was unused by tests. Updated some packages. Fixed plenty of next-page tests that used first-page data. Added test filename to test names. Fixed some test target values to reflect repository state to reflect -23. Fixed next page finding logic selecting any page. Removed test concerning main repo pagination. Tons of selector fixes. Fixed many test error messages.