nelsonic / github-scraper

🕷 🕸 crawl GitHub web pages for insights we can't GET from the API ... 💡
434 stars 96 forks source link

Issue with some types of user names. #60

Closed sAbakumoff closed 9 years ago

sAbakumoff commented 9 years ago
scrapper('hangouts/followers', function(err, data){
  console.log(err);
});

produces

However, this user does exist : https://github.com/hangouts/followers

nelsonic commented 9 years ago

@sAbakumoff well spotted! thanks for posting this issue. I will look into why the switcher is failing. :+1:

nelsonic commented 9 years ago

Ah... I must have coded this when I was very tired... thanks for highlighting this. :+1: The url_validator was meant to check for urls beginning in http or https but instead only checked for the character h ... duh...!

nelsonic commented 9 years ago

@sAbakumoff see latest version on NPM. :+1: