nelsonic / github-scraper

🕷 🕸 crawl GitHub web pages for insights we can't GET from the API ... 💡
432 stars 96 forks source link

Fix minor typo in readme file #63

Closed jinjorge closed 8 years ago

jinjorge commented 8 years ago

Awesome repo :+1:

nelsonic commented 8 years ago

well spotted. thanks for fixing. :+1:

nelsonic commented 8 years ago

@jinjorge annoyingly one of the tests needs to be updated... see: https://travis-ci.org/nelsonic/github-scraper/builds/95630818#L1358

If you have a minute to "fix" it, Line 14 of /test/repo.test.js needs to be changed to:

 t.ok(stats.langs[0].indexOf('HTML') > -1, 'Language is: '+ stats.langs);

Let me know if you have :hourglass_flowing_sand: thanks again!

jinjorge commented 8 years ago

@nelsonic will do. Going to also removed the commented out lines in the code

jinjorge commented 8 years ago

no bueno :(

Investigating....

jinjorge commented 8 years ago

my bad... wrong branch. Fixing shortly

jinjorge commented 8 years ago

sorry... this is ugly. feel free to close it and I'll fix it in a new PR

jinjorge commented 8 years ago

fixed it here https://github.com/nelsonic/github-scraper/pull/64