search

nelsontky / duke

Starter code for the Duke project
0 stars 0 forks source link

Feedback on week 5 project progress for nelsontky #6

Open nus-se-bot opened 4 years ago

nus-se-bot commented 4 years ago

Leftovers from the previous week

Progress of this week

nelsontky commented 4 years ago

Leftovers from the previous week

* [x]  A version tagged `Level-10` is in the repo(exclamation try to do by next milestone)

Progress of this week

* [x]  At least 2 PRs are in your fork #5 #4 (heavy_check_mark well done!)

* [x]  A version tagged `A-Assertions` is in the repo(exclamation try to do by next milestone)

* [x]  A version tagged `A-CodeQuality` is in the repo(exclamation try to do by next milestone)

* [x]  You have no tag from categories B/C/D(exclamation try to do by next milestone)

Note: the above observation was done by the CS2103-feedback-bot and covers changes up to 2020-02-14 00:00:00 only. If you think the above observation is incorrect, please let us know by replying in this thread. Please include links to relevant PRs/comments in your response.

Hi as you can see I've made them into branches as the instructions were unclear: https://github.com/nelsontky/duke/branches

All 4 versions were branches.

okkhoy commented 4 years ago

The part about tagging the commits (in this case merge commits) is a standing instruction like all earlier enhancements (levels + extensions). You can now tag them appropriately.