search

nem0 / LumixEngine

3D C++ Game Engine - yet another open source game engine
MIT License
3.46k stars 390 forks source link

Audio - effects #611

Open nem0 opened 8 years ago

nem0 commented 8 years ago

possible others from

ghost commented 6 years ago

I implemented the Chorus effect.. If it meets your standards I can try the other effects as well.

nem0 commented 6 years ago

It looks good. Only one small issue, destroyChorusZone should not be in API == should not be virtual. It can be accessed by AudioSceneImpl::destroyComponent as are the others.

ghost commented 6 years ago

Made the fix.

nem0 commented 6 years ago

I meant it should not even be in audio_scene.h :) Sorry about that, it was a bit misleading as I wrote it

ghost commented 6 years ago

Not a problem, here it is.

nem0 commented 6 years ago

:+1: