nem0 / LumixEngine

3D C++ Game Engine - yet another open source game engine
MIT License
3.46k stars 392 forks source link

If you have the shader panel docked, the right click context menu for the shader panel works for every panel. #861

Closed antonyjones67 closed 8 years ago

antonyjones67 commented 8 years ago

It seems like the context menu is not verifying what panel it is clicked in.

nem0 commented 8 years ago

Thanks for the report. To be honest Shader editor was not maintained for some time, I need to clean it up a bit.

antonyjones67 commented 8 years ago

Cool. I think this might be true for keyboard commands. Do you think this is just a Shader Editor problem? Or does it apply to docked panels in general?

nem0 commented 8 years ago

It is not related to the docking system itself. This is the only popup done like this:

    if(ImGui::IsMouseClicked(1))
    {
        ImGui::OpenPopup("context_menu");
    }

while others are bind to a specific button

    if (ImGui::Button(Lumix::StaticString<30>("...###br", str_id)))
    {
        ImGui::OpenPopup(popup_name);
    }
antonyjones67 commented 8 years ago

oh wow that was easy. :) nice

antonyjones67 commented 8 years ago

thank you.

nem0 commented 8 years ago

Things are usually easy with imgui

antonyjones67 commented 8 years ago

So cool. :)