Fix alignment issues in data reading and skeleton root identification

nem0 / OpenFBX

Lightweight open source FBX importer

MIT License

1.15k stars 135 forks source link

Fix alignment issues in data reading and skeleton root identification #96

Closed jeongseok-meta closed 4 months ago

jeongseok-meta commented 4 months ago

Fixed misaligned reads caused by casting char to float by introducing read_value() that uses a union and memcpy to address the issue.
Fixed a bug in reading skeleton roots by adding a "Root" type check for skeleton joint roots in addition to "LimbNode".
~~Updated to cross-platform typedefs~~
Enabled double precision support by removing hard-coded preprocessor directives.
Improved the cross-platform compatibility of the isEndLine() function.

nem0 commented 4 months ago

Hi, other then leaking std header it looks ok.

jeongseok-meta commented 4 months ago

It's good to know that not including the STL header is a design choice of this library. Thank you for reviewing!

nem0 commented 4 months ago

FYI: cstdint is preprocessed to 70KB on my MSVC. While not so bad, still better to avoid leaking it from the ofbx.h, which itself can be included many times.

jeongseok-meta commented 4 months ago

FYI: cstdint is preprocessed to 70KB on my MSVC. While not so bad, still better to avoid leaking it from the ofbx.h, which itself can be included many times.

Good to know that. I've removed it from the header. Please take another look when you have a chance. Thank you!

nem0 commented 4 months ago

Thanks, merged. I made a small change to use floats by default, so nothing changed for current user. But I change it so user can switch to doubles without changing ofbx source code.

jeongseok-meta commented 4 months ago

Makes sense to me, thanks!