nemaara / A_New_Order

add-on campaign for The Battle for Wesnoth featuring the Akladians; originally by szopen
https://forums.wesnoth.org/viewtopic.php?f=8&t=6486
GNU General Public License v2.0
11 stars 7 forks source link

Copy over changes from other repo (mostly a continuation of validator fixes) #163

Closed cooljeanius closed 10 months ago

cooljeanius commented 11 months ago

This PR contains the following:

See the following issues:

cooljeanius commented 10 months ago

I assume you playtested these changes? As in nothing breaks when you load the scenarios.

I only tested the first few scenarios, since the --validate-addon flag will check the entire campaign upon just loading the first scenario... trying to switch to some other scenarios with the :cl in-game debug command, though, reveals a bug that was probably already there previously that I'd never noticed before due to not having tried switching levels this way: when skipping from S04 ("Battle of Barnon") to S05 ("The Swamp Things") I get:

20240103 01:29:55 info wml: A [recall] tag with the following content failed:
show = no
side = 1
x = 1
y = 1
20240103 01:29:57 error wml: [unstore_unit]: variable 'ano_reme_stored' doesn't contain unit data

I'll open a separate issue about that. Note that I'm planning several more PRs and another full playthrough before the next release, so if anything else comes up, I can fix it later...

cooljeanius commented 10 months ago

I'll open a separate issue about that.

...ok, I opened #165 for it.