nemaara / A_New_Order

add-on campaign for The Battle for Wesnoth featuring the Akladians; originally by szopen
https://forums.wesnoth.org/viewtopic.php?f=8&t=6486
GNU General Public License v2.0
11 stars 7 forks source link

British English spellings vs. American English spellings: create an `en_US` translation, and teach spellchecker to accept Britishisms #206

Closed cooljeanius closed 1 month ago

cooljeanius commented 4 months ago

whichever of my spellcheckers that wmllint is using (it looks like it might have changed from AppleSpell to Aspell?) has started complaining about various British spellings used in the add-on:

# Spell-checking with Aspell
"/Users/ericgallager/Library/Containers/org.wesnoth.Wesnoth/Data/Library/Application Support/Wesnoth_1.16/data/add-ons/A_New_Order/scenarios/09_Hired_Swords.cfg", line 331: possible misspelling "honoured" 
"/Users/ericgallager/Library/Containers/org.wesnoth.Wesnoth/Data/Library/Application Support/Wesnoth_1.16/data/add-ons/A_New_Order/scenarios/09_Hired_Swords.cfg", line 440: possible misspelling "honour" 
"/Users/ericgallager/Library/Containers/org.wesnoth.Wesnoth/Data/Library/Application Support/Wesnoth_1.16/data/add-ons/A_New_Order/scenarios/16_Choosing_the_Best.cfg", line 74: possible misspelling "recognised" 
"/Users/ericgallager/Library/Containers/org.wesnoth.Wesnoth/Data/Library/Application Support/Wesnoth_1.16/data/add-ons/A_New_Order/scenarios/16_Choosing_the_Best.cfg", line 78: possible misspelling "recognise" 
"/Users/ericgallager/Library/Containers/org.wesnoth.Wesnoth/Data/Library/Application Support/Wesnoth_1.16/data/add-ons/A_New_Order/scenarios/20_Okladia.cfg", line 26: possible misspelling "behaviour." 
"/Users/ericgallager/Library/Containers/org.wesnoth.Wesnoth/Data/Library/Application Support/Wesnoth_1.16/data/add-ons/A_New_Order/scenarios/21a_Abducted_Bride.cfg", line 77: possible misspelling "neighbouring" 
"/Users/ericgallager/Library/Containers/org.wesnoth.Wesnoth/Data/Library/Application Support/Wesnoth_1.16/data/add-ons/A_New_Order/scenarios/21c_Ruins_of_the_Past.cfg", line 19: possible misspelling "honour." 
"/Users/ericgallager/Library/Containers/org.wesnoth.Wesnoth/Data/Library/Application Support/Wesnoth_1.16/data/add-ons/A_New_Order/scenarios/21c_Ruins_of_the_Past.cfg", line 42: possible misspelling "honour" 
"/Users/ericgallager/Library/Containers/org.wesnoth.Wesnoth/Data/Library/Application Support/Wesnoth_1.16/data/add-ons/A_New_Order/scenarios/21c_Ruins_of_the_Past.cfg", line 58: possible misspelling "civilised" 
"/Users/ericgallager/Library/Containers/org.wesnoth.Wesnoth/Data/Library/Application Support/Wesnoth_1.16/data/add-ons/A_New_Order/scenarios/25_The_Awakening.cfg", line 298: possible misspelling "neighbouring" 
"/Users/ericgallager/Library/Containers/org.wesnoth.Wesnoth/Data/Library/Application Support/Wesnoth_1.16/data/add-ons/A_New_Order/units/_main.cfg", line 35: possible misspelling "civilisation" 
"/Users/ericgallager/Library/Containers/org.wesnoth.Wesnoth/Data/Library/Application Support/Wesnoth_1.16/data/add-ons/A_New_Order/units/akladians/Akladian_Clansman.cfg", line 18: possible misspelling "armoured" 
"/Users/ericgallager/Library/Containers/org.wesnoth.Wesnoth/Data/Library/Application Support/Wesnoth_1.16/data/add-ons/A_New_Order/units/akladians/Akladian_Fastfoot.cfg", line 18: possible misspelling "armour," 
"/Users/ericgallager/Library/Containers/org.wesnoth.Wesnoth/Data/Library/Application Support/Wesnoth_1.16/data/add-ons/A_New_Order/units/akladians/Akladian_LightInfantry.cfg", line 17: possible misspelling "armour" 
"/Users/ericgallager/Library/Containers/org.wesnoth.Wesnoth/Data/Library/Application Support/Wesnoth_1.16/data/add-ons/A_New_Order/units/akladians/Akladian_Shieldguard.cfg", line 24: possible misspelling "armour," 
"/Users/ericgallager/Library/Containers/org.wesnoth.Wesnoth/Data/Library/Application Support/Wesnoth_1.16/data/add-ons/A_New_Order/units/akladians/Akladian_Sturmknight.cfg", line 24: possible misspelling "armour" 
"/Users/ericgallager/Library/Containers/org.wesnoth.Wesnoth/Data/Library/Application Support/Wesnoth_1.16/data/add-ons/A_New_Order/units/akladians/Akladian_Warrior.cfg", line 18: possible misspelling "neighbouring" 
"/Users/ericgallager/Library/Containers/org.wesnoth.Wesnoth/Data/Library/Application Support/Wesnoth_1.16/data/add-ons/A_New_Order/units/macros/amla.cfg", line 7: possible misspelling "Armoured" 

Should I replace them with their American spellings in the source strings (breaking translations in the process), or create a separate en_US translation that uses American spellings?

GitMensch commented 4 months ago

The split sounds reasonable to me

cooljeanius commented 4 months ago

The split sounds reasonable to me

...so, to be clear, that's the latter of the two options, correct?

GitMensch commented 4 months ago

A separate en_US which is based on the current en seems reasonable to me. As you already found this will ensure that no existing translations need updates to match the new msgids.

MultiSeptim commented 4 months ago

Both options suit me.

cooljeanius commented 3 months ago

OK, I'll start working on a separate en_US translation for the 1.8.0 release; I want to get 1.7.0 out the door first, though...

cooljeanius commented 3 months ago

OK, I'll start working on a separate en_US translation for the 1.8.0 release; I want to get 1.7.0 out the door first, though...

Update: I opened #217 for this.