Scenario 27 ("Orannon") minor nits

[cooljeanius]

• [ ] Color-changing animation code when Deorien drives off Grekulak's darkness on turn 16 doesn't really work or look right (and it also takes too long, now that I added delays to it)
• [ ] Bridge-destruction dialogue needs to be improved based on scenario conditions
• [ ] Only the single-tile bridges should be destructible, not the 2-tile one (or at least, not the whole thing of it)
• [x] Side 8's recruitment_pattern should be updated when it becomes allowed to recruit new units
• [ ] Don't let the {RISE_UP_RISE_UP} macro capture villages (at least not on EASY), for consistency with how the "Plague" mechanic works
• [ ] Handle the case where victory is reached before Grekulak's arrival
• [ ] Ensure all level 3 units are counted properly for the final score tallying (S30, "Final") (low priority, as I'm pretty sure they already are)
• [x] Change music on Grekulak's arrival, and when he tries his spell of darkness
• [ ] Countdown timer for how many turns Lorin has to retreat
• [ ] Clean up moveto event for when Lorin arrives at keep, so there is dialogue if it's reached between turns 13 and 18, too
• [x] Ensure zombie IDs are properly quoted

[cooljeanius]

as of 1f12db6, PR #53 would let us check off checkbox number 4

[cooljeanius]

(the "help wanted" tag I just added is just for the first 3 checkboxes; I ought to be able to handle the rest myself)

[cooljeanius]

So, #82 is kind of a more specific instance of what I was thinking of for the second checkbox; my original idea for the checkbox was to have "any bridges" changed to "any more bridges" when one has already been destroyed, and to adjust the "today" based on the passage of time, though, so I'm leaving that as a separate issue

[cooljeanius]

PR #83 should let us check off checkbox 8 here.

[cooljeanius]

PR #83 should let us check off checkbox 8 here.

ok so that's merged so I checked it off, although the music might need some further adjustment...

[cooljeanius]

@Toranks did you notice anything else that I should add here?

(Edit: besides the thing #122 is supposed to fix, that is... which isn't something I've noticed myself, tbh)

[cooljeanius]

Oh, I just thought of another one: a turn counter for the phase of the scenario where Lorin has to retreat to your keep

[cooljeanius]

Oh, I just thought of another one: a turn counter for the phase of the scenario where Lorin has to retreat to your keep

Oh, and one more (related) thing: if Lorin is off the keep when Deorien tells her that she has to move back there, there should be a moveto event for when she reaches her destination.

[Toranks]

What? That already exists, no?

https://github.com/nemaara/A_New_Order/blob/510c038293c43b995c759ff2f6ec13bff2356161/scenarios/27_Orannon.cfg#L1535

About the counter, I think the easiest way would be to add a new defeat objective at the end of this event if you don't get "Lady Lorin to the Keep before turn X"(18+6), instead of bothering the player with a counter every turn.

https://github.com/nemaara/A_New_Order/blob/510c038293c43b995c759ff2f6ec13bff2356161/scenarios/27_Orannon.cfg#L1379

[cooljeanius]

What? That already exists, no?

https://github.com/nemaara/A_New_Order/blob/510c038293c43b995c759ff2f6ec13bff2356161/scenarios/27_Orannon.cfg#L1535

Ah, I guess the message just didn't fire for me for some reason... guess I'd better check where ano_lorin_pregnant is set, so I can add a branch for when it isn't "yes"...

[cooljeanius]

oh wait I think I see where my misconception was; I thought the point at which I had to start withdrawing her was on turn 13 when Grekulak shows up, but it actually isn't until later on turn 18 when the timer starts...

[cooljeanius]

one more thing that @Toranks noted on Discord: apparently there's a zombie ID that needs quoting:

1.17/A_New_Order/scenarios/27_Orannon.cfg:        id=Zombie $ano_N

[cooljeanius]

one more thing that @Toranks noted on Discord: apparently there's a zombie ID that needs quoting:

1.17/A_New_Order/scenarios/27_Orannon.cfg:        id=Zombie $ano_N

ok this one is done as of e6d4809

[cooljeanius]

• [ ] Color-changing animation code when Deorien drives off Grekulak's darkness on turn 16 doesn't really work or look right (and it also takes too long, now that I added delays to it)

@Forestdragon-wesnoth I think this one is related to something you noted about the color in this scenario

[ForestDragon-wesnoth]

@ForestDragon-wesnoth I think this one is related to something you noted about the color in this scenario

well, the color-shift looked pretty interesting at the end, but that's pretty much it as far as my opinion of it goes

[cooljeanius]

So, #82 is kind of a more specific instance of what I was thinking of for the second checkbox; my original idea for the checkbox was to have "any bridges" changed to "any more bridges" when one has already been destroyed, and to adjust the "today" based on the passage of time, though, so I'm leaving that as a separate issue

See also: issue #187