search

nemasu / asmttpd

Web server for Linux written in amd64 assembly.
GNU General Public License v2.0
3.03k stars 199 forks source link

Make code commenting consistent #36

Open triforce opened 7 years ago

triforce commented 7 years ago

Only a very trivial issue however code comments seem a bit inconsistent. Should we standardize on:

mov rax, rbx ; This is a comment

Space after ';' and start with capital letter?

nemasu commented 6 years ago

Hmmmmmmm, I can't really make up my mind haha. So far I think I prefer it without a leading space a bit more, like: mov rax, rbx ;This is a comment. Probably jut because of habit with other languages:

a = {} #This is a comment.
cout << "blah"; //This is a comment.
System.out.println("blah"); //Another comment.
etc.

That being said, the example in the yasm manual does have the space: label: instruction operands ; comment So let's go with that then.

nemasu commented 3 years ago

Hi, would you be able to update your branch to the latest and make a PR?