search

nemccarthy / stash-pullrequest-builder-plugin

A Jenkins plugin for Building Stash Pull Requests
https://wiki.jenkins-ci.org/display/JENKINS/Stash+pullrequest+builder+plugin
Other
64 stars 130 forks source link

Update to Apache httpclient 4.5.2. This allows to use proxies settings #103

Closed loicalbertin closed 7 years ago

loicalbertin commented 8 years ago

Fixes #65

Update to Apache httpclient 4.5.2.

This allows to use proxies settings defined as Java properties (-DproxyHost, -DproxyPort, -Dhttp.proxyHost, -Dhttps.proxyHost, -Dhttp.nonProxyHosts, ...)

Tested on Jenkins v1.625.3 and v2.26, Stash v4.0.4.

loicalbertin commented 8 years ago

Hi @nemccarthy

Any feedback regarding this PR?

Loïc

alexbrazier commented 7 years ago

@loicalbertin Thanks, this looks great! Do you know if it is possible/easy to get a custom build of the plugin with this change so that I can start using it now?

@nemccarthy What do you think of this? Any chance of it being merged soon?

loicalbertin commented 7 years ago

Hi @alexbrazier

You can checkout my fork and build it with maven.

git clone https://github.com/loicalbertin/stash-pullrequest-builder-plugin.git
cd stash-pullrequest-builder-plugin
git checkout migrate-to-httpclient-4x
mvn clean install

hope this helps. Loïc

alexbrazier commented 7 years ago

@loicalbertin Thanks! I've just tested this and it works perfectly (Stash 3.4.1, Jenkins 2.7.4)

loicalbertin commented 7 years ago

Thanks @nemccarthy!