search

nemccarthy / stash-pullrequest-builder-plugin

A Jenkins plugin for Building Stash Pull Requests
https://wiki.jenkins-ci.org/display/JENKINS/Stash+pullrequest+builder+plugin
Other
64 stars 130 forks source link

Added options to mark a pull request as Approved or Needs Work #123

Open tettaji opened 7 years ago

tettaji commented 7 years ago

When set, this automatically marks a pull request as Approved or Needs Work if a build succeeds or fails, respectively.

nitrocode commented 7 years ago

@tettaji nice PR! Thank you for the work.

@nemccarthy Hi Nathan. Do you think this PR can be merged into main branch? If not, what can be improved on to get it merged?

It would definitely help push Jenkins as more of an authority on our builds if it could set PRs to needs_work when the code breaks the build.

missedone commented 7 years ago

👍 I verified this PR in our Jenkins instance, it works like a charm.

Macarse commented 7 years ago

@tettaji do you mind squashing commits in this PR so it's easier to cherry-pick?

tettaji commented 7 years ago

Thanks for the comments!

@Macarse sure, I've just squashed everything into one commit.

dawidmalina commented 6 years ago

When this can be merged?

tettaji commented 6 years ago

It would be cool if this could be merged before its one year anniversary. :P

Macarse commented 6 years ago

hehe I ended up forking and use my own version by cherry-picking what I need.

phschoen commented 6 years ago

oh man still open? congrats to a pullrequest which is 16months open @nemccarthy

batmat commented 5 years ago

Unmaintained repo, unrelated to the Jenkins Project FYI. See https://github.com/nemccarthy/stash-pullrequest-builder-plugin/issues/158

tettaji commented 5 years ago

@batmat thanks for the heads up.

I haven't been using Jenkins for a while, but if anyone wants to fork this PR and submit it to the officially maintained repo, feel free to do so.

dawidmalina commented 5 years ago

@jakub-bochenski would be nice if you could take over this pull request as @tettaji have no more interest in doing it. But he is ok with taking his code.

jakub-bochenski commented 5 years ago

@dawidmalina I don't plan to work on this.

You can file a PR on https://github.com/jenkinsci/stash-pullrequest-builder-plugin/ if you want this integrated. One thing I would ask for if you do is some more context for this change. Right now I don't see why would one need this instead of just requiring a passing build to merge a PR.

mrdima commented 5 years ago

I have an interest, I'll try add the PR to the jenkinsci version of this repo