JENKINS-52818 breaks build URL on Stash updates

nemccarthy / stash-pullrequest-builder-plugin

A Jenkins plugin for Building Stash Pull Requests

https://wiki.jenkins-ci.org/display/JENKINS/Stash+pullrequest+builder+plugin

Other

64 stars 130 forks source link

JENKINS-52818 breaks build URL on Stash updates #148

Closed Alex-Vol-SV closed 4 years ago

Alex-Vol-SV commented 6 years ago

The recent JENKINS-52818 changes cause this plugin to show this for each passing/failing build in Stash

[✓ BUILD SUCCESS]( PLEASE SET JENKINS ROOT URL FROM GLOBAL CONFIGURATION job/some-PR/18/) - Build #18 which took 35 min

The issue was the incorrectly referenced JenkinsLocationConfiguration which should not be instantiated but fetched with the static accessor.

I am submitting a PR with the fix.

rambrus commented 5 years ago

@Alex-Vol-SV any update on this? I also experience this issue on:

Jenkins ver. 2.154
Stash Pullrequest Builder Plugin ver. 1.7.0

Alex-Vol-SV commented 5 years ago

I have no control over this. I offered the pull request with the fix but I think this plugin is no longer maintained by @nemccarthy

I created a private build for my CI environment with this fix and a few others cherry-picked from some of the open pull requests.

rambrus commented 5 years ago

oh, okay, I see. thanks for the info! I'll do the same.

batmat commented 5 years ago

See https://github.com/nemccarthy/stash-pullrequest-builder-plugin/issues/158

nemccarthy commented 4 years ago

Please raise in https://github.com/jenkinsci/stash-pullrequest-builder-plugin this is being maintained. If you would like to be a collaborator you can apply with jenkins org and there should be maintainers already looking after the repo in the official jenkins org.