search

nemccarthy / stash-pullrequest-builder-plugin

A Jenkins plugin for Building Stash Pull Requests
https://wiki.jenkins-ci.org/display/JENKINS/Stash+pullrequest+builder+plugin
Other
64 stars 130 forks source link

Variable ${pullRequestCommit} was removed #37

Closed dylankiss closed 9 years ago

dylankiss commented 9 years ago

The documentation states that when using the "Notify Stash Instance" post-build step, you should use the variable ${pullRequestCommit} as Commit SHA-1 value. However that variable has been removed in the latest release. Is there a specific reason for this, or could you just bring that variable back? It would be much appreciated.

thalesac commented 9 years ago

+1 on this.. There is a reason why this was reverted?

https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/9288db11a72b5527addbb822df3d0a43587898c0

indrgun commented 9 years ago

What is the variable to set as Commit SHA-1 value in the meantime for Stash Notifier post-build action? Was it there in v1.3.0? I used latest v1.3.1.

nemccarthy commented 9 years ago

Adding this one back in. Look out for the 1.4 release

nullfieldio commented 9 years ago

I just upgraded to 1.4.1 and I am still not seeing the ${sourceCommitHash} get set.

Cherum commented 9 years ago

We're on 1.4.2 and the variable is not set. What's the status of this?

nemccarthy commented 9 years ago

This should be set and is working in 1.4.2 of the plugin. Please make sure you use; $sourceCommitHash in the notify stash plugin.

PixnBits commented 8 years ago

@Cherum I have the same issue, I think #89 has the fix due to SECURITY-170

PixnBits commented 8 years ago

@nemccarthy FWIW this is an issue again due to SECURITY-170 and clusters that don't set hudson.model.ParametersAction.keepUndefinedParameters or hudson.model.ParametersAction.safeParameters I'm hoping #89 has the fix so we can use $sourceCommitHash again 🙏