search

nemerle / dcc

This is a heavily updated version of the old DOS executable decompiler DCC
GNU General Public License v2.0
146 stars 27 forks source link

makedsig - do not remove duplicates #23

Closed lab313ru closed 8 years ago

lab313ru commented 8 years ago

When generating sig-file it will be better to use on of duplicated records instead of removing both of them.

Or, if it works that way already, allow to choose which of duplicates to use.

nemerle commented 8 years ago

The dcc will not have any ability to properly know which function it found, thus decompilation result will be wrong - discarding both duplicates is the right move in that case

lab313ru commented 8 years ago

You didn't understand. I mean the same signatures for some lib-functions. One of two duplicated items we should use anyway.

As I found, makedsig uses first item in every case.

lab313ru commented 8 years ago

Hmm, bad idea. Prompting at every duplicate is very long procedure to generate then.