configure SVN proxy using system properties

nemerosa / versioning

Gradle plug-in to generate version information from the SCM branch (Git or Svn)

MIT License

200 stars 40 forks source link

configure SVN proxy using system properties #51

Closed Taeradan closed 6 years ago

Taeradan commented 6 years ago

Proxy settings are ignored if a custom SVN authentication manager is used. This patch configures the proxy in the custom authentication manager using the system properties http.proxyHost, http.proxyPort,http.proxyUser and http.proxyPassword.

dcoraboeuf commented 6 years ago

Hi,

Thanks for the PR. I definitely would like to merge it and release it.

Could you please merge the master branch and solve the conflicts.

Thanks, Damien

Taeradan commented 6 years ago

Hi,

As I'm alone on my branch, I just rebased it on top of yours and force pushed it to my repository. It should be mergeable now.

By the way, it is running flawlessly in a business environment since monday, so I consider it stable (considering that the proxy setup here is not trivial, depending of the VLAN, office, etc...).

dcoraboeuf commented 6 years ago

Available in 2.7.1