search

nemethviktor / GeoTagNinja

A lightweight photo geotagger for Windows.
https://geotag.ninja
GNU General Public License v3.0
25 stars 2 forks source link

no folder should be selected on first opening #120

Closed unosakk closed 2 months ago

unosakk commented 2 months ago

Describe the bug Opened the app for the first time and the application chose my onedrive with cloud only pictures. It is now downloading them on to the device for geotagninja to use. it serveral G on pictures ...

To Reproduce Steps to reproduce the behavior:

  1. Open app

Expected behavior user can choose the folder?

Screenshots image

Desktop (please complete the following information):

Additional context Canceling download crashes the app See the end of this message for details on invoking just-in-time (JIT) debugging instead of this dialog box.

** Exception Text ** System.FormatException: Input string was not in a correct format. at System.Number.ParseDouble(String value, NumberStyles options, NumberFormatInfo numfmt) at GeoTagNinja.Helpers.HelperExifDataPointInteractions.AdjustLatLongNegative(String point) at GeoTagNinja.Model.TagsToModelValueTransformations.T2M_GPSLatLong(ElementAttribute attribute, String parseResult, IDictionary2 parsed_Values, Func2 ParseMissingAttribute) at GeoTagNinja.Model.DirectoryElement.ParseAttribute(ElementAttribute attribute, IDictionary2 parsedValues, List1 parsedFails, IDictionary2 tags, Int32 callDepth) at GeoTagNinja.Model.DirectoryElement.ParseAttributesFromExifToolOutput(IDictionary2 dictTagsIn) at GeoTagNinja.Model.DirectoryElementCollection.ParseFolderOrFileListToDEs(String folderOrCollectionFileName, Action`1 statusMethod, Boolean collectionModeEnabled) at GeoTagNinja.FrmMainApp.lvw_FileList_LoadOrUpdate() at GeoTagNinja.FrmMainApp.d46.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.AsyncMethodBuilderCore.<>c.b6_0(Object state)

** Loaded Assemblies ** mscorlib Assembly Version: 4.0.0.0 Win32 Version: 4.8.9261.0 built by: NET481REL1LAST_C CodeBase: file:///C:/Windows/Microsoft.NET/Framework/v4.0.30319/mscorlib.dll

GeoTagNinja Assembly Version: 1.15.8973.39526 Win32 Version: 1.15.8973.39526 CodeBase: file:///C:/Program%20Files/GeoTagNinja/GeoTagNinja.exe

System.Windows.Forms Assembly Version: 4.0.0.0 Win32 Version: 4.8.9251.0 built by: NET481REL1LAST_C CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Windows.Forms/v4.0_4.0.0.0__b77a5c561934e089/System.Windows.Forms.dll

CommandLine Assembly Version: 2.9.1.0 Win32 Version: 2.9.1.0 CodeBase: file:///C:/Program%20Files/GeoTagNinja/CommandLine.DLL

System Assembly Version: 4.0.0.0 Win32 Version: 4.8.9261.0 built by: NET481REL1LAST_C CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System/v4.0_4.0.0.0__b77a5c561934e089/System.dll

System.Drawing Assembly Version: 4.0.0.0 Win32 Version: 4.8.9032.0 built by: NET481REL1 CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Drawing/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Drawing.dll

System.Core Assembly Version: 4.0.0.0 Win32 Version: 4.8.9261.0 built by: NET481REL1LAST_C CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Core/v4.0_4.0.0.0__b77a5c561934e089/System.Core.dll

NLog Assembly Version: 5.0.0.0 Win32 Version: 5.2.3.1999 CodeBase: file:///C:/Program%20Files/GeoTagNinja/NLog.DLL

System.Data Assembly Version: 4.0.0.0 Win32 Version: 4.8.9214.0 built by: NET481REL1LAST_B CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_32/System.Data/v4.0_4.0.0.0__b77a5c561934e089/System.Data.dll

System.Xml Assembly Version: 4.0.0.0 Win32 Version: 4.8.9032.0 built by: NET481REL1 CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll

Microsoft.WindowsAPICodePack.Shell Assembly Version: 1.1.0.0 Win32 Version: 1.1.0.0 CodeBase: file:///C:/Program%20Files/GeoTagNinja/Microsoft.WindowsAPICodePack.Shell.DLL

Microsoft.WindowsAPICodePack Assembly Version: 1.1.0.0 Win32 Version: 1.1.0.0 CodeBase: file:///C:/Program%20Files/GeoTagNinja/Microsoft.WindowsAPICodePack.DLL

System.Configuration Assembly Version: 4.0.0.0 Win32 Version: 4.8.9032.0 built by: NET481REL1 CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Configuration/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Configuration.dll

Accessibility Assembly Version: 4.0.0.0 Win32 Version: 4.8.9032.0 built by: NET481REL1 CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/Accessibility/v4.0_4.0.0.0__b03f5f7f11d50a3a/Accessibility.dll

System.Numerics Assembly Version: 4.0.0.0 Win32 Version: 4.8.9032.0 built by: NET481REL1 CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Numerics/v4.0_4.0.0.0__b77a5c561934e089/System.Numerics.dll

System.Data.SQLite Assembly Version: 1.0.118.0 Win32 Version: 1.0.118.0 CodeBase: file:///C:/Program%20Files/GeoTagNinja/System.Data.SQLite.DLL

System.Transactions Assembly Version: 4.0.0.0 Win32 Version: 4.8.9032.0 built by: NET481REL1 CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_32/System.Transactions/v4.0_4.0.0.0__b77a5c561934e089/System.Transactions.dll

Newtonsoft.Json Assembly Version: 13.0.0.0 Win32 Version: 13.0.3.27908 CodeBase: file:///C:/Program%20Files/GeoTagNinja/Newtonsoft.Json.DLL

Microsoft.Web.WebView2.Core Assembly Version: 1.0.2535.41 Win32 Version: 1.0.2535.41 CodeBase: file:///C:/Program%20Files/GeoTagNinja/Microsoft.Web.WebView2.Core.DLL

System.EnterpriseServices Assembly Version: 4.0.0.0 Win32 Version: 4.8.9032.0 built by: NET481REL1 CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_32/System.EnterpriseServices/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.EnterpriseServices.dll

System.Data.DataSetExtensions Assembly Version: 4.0.0.0 Win32 Version: 4.8.9032.0 built by: NET481REL1 CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Data.DataSetExtensions/v4.0_4.0.0.0__b77a5c561934e089/System.Data.DataSetExtensions.dll

CsvHelper Assembly Version: 30.0.0.0 Win32 Version: 30.0.1.0 CodeBase: file:///C:/Program%20Files/GeoTagNinja/CsvHelper.DLL

Microsoft.Bcl.AsyncInterfaces Assembly Version: 8.0.0.0 Win32 Version: 8.0.23.53103 CodeBase: file:///C:/Program%20Files/GeoTagNinja/Microsoft.Bcl.AsyncInterfaces.DLL

Microsoft.Web.WebView2.WinForms Assembly Version: 1.0.2535.41 Win32 Version: 1.0.2535.41 CodeBase: file:///C:/Program%20Files/GeoTagNinja/Microsoft.Web.WebView2.WinForms.DLL

** JIT Debugging ** To enable just-in-time (JIT) debugging, the .config file for this application or computer (machine.config) must have the jitDebugging value set in the system.windows.forms section. The application must also be compiled with debugging enabled.

For example:

When JIT debugging is enabled, any unhandled exception will be sent to the JIT debugger registered on the computer rather than be handled by this dialog box.

nemethviktor commented 2 months ago

Hi,

You can set the default folder in Settings image

We can't have "no folder" as a default I'm afraid, the assumption is that there is something defined for the app to start in. Currently the default is the user's "Pictures" when nothing is set. While I could change that to something like "My Computer", it's a little awkward and the users can change it after the first launch to whatever works for them.

As for the crash I think that has been fixed in a yet unreleased version https://drive.google.com/open?id=13uYyCQE31JlSUb2iamKdYh55bGNqQFOW&usp=drive_fs

unosakk commented 2 months ago

already deleted my onedrive from the pc and got in without a crash. Can´t test the unreleased version.

Didn´t find any easy way, to change that onedrive is not the default picture directory. For my case using picture is the worse option then "my computer". But it´s the developers choice. I quess using and seperate conf fail for startup folder parameter isn´t a better solution .

nemethviktor commented 2 months ago

Why don't you set a default in Settings as per screenshot?

unosakk commented 2 months ago

It crashed before going to settings was possible. If the crash is fixed. It should be okey now for onedrive users. If i put onedrive back, i aill try to remember and test

nemethviktor commented 2 months ago

See if it works with the unpublished version. If still not I'll dig into it a bit more. Btw technically there is a settings file, more precisely after install, upon the first launch it gets created at c:\Users\username\AppData\Roaming\GeoTagNinja\database.sqlite

You can try something like modifying the value in settings image

but it might be a little tricky if you're not familiar with sqlite stuff.