search

nemiah / phpFinTS

PHP library to communicate with FinTS/HBCI servers
MIT License
131 stars 40 forks source link

Add "isStorno" information to transactions #342

Closed DanielEgenolf closed 3 years ago

DanielEgenolf commented 3 years ago

Hi, I would like to get information about "isStorno". Is it possible to accept this pull-request? Thanks and kind regards Daniel

nemiah commented 3 years ago

Thank you for your PR. Looks fine to me.

@Philipp91 comments?

Philipp91 commented 3 years ago

Looks good. I guess this could be squashed in a single commit.

DanielEgenolf commented 3 years ago

Thanks for the comments and the hint. Sure, you can use a squashed merge. Or do I have to do something here?

DanielEgenolf commented 3 years ago

Is something missing here or why isn't this PR merged into the master yet?

nemiah commented 3 years ago

Sorry, life :woman_shrugging: Merging…

DanielEgenolf commented 3 years ago

@nemiah: Thank you very much. No problem!