PHP 8.1 changes

[fbett]

There are some changes needed for PHP 8.1:

• Travis Tests using PHP 8.1
• trim(null) is deprecated, but values of "$prepared" are nullable.

The biggest commit is about:

• Implementing the Serializable interface without implementing serialize and unserialize methods is deprecated. Magic methods "serialize" and "unserialize" are available since PHP 7.4

All changes should be full compatible to previous PHP versions:

• Earlier than PHP 7.4: Serializable interface's methods "serialize(): string" and "unserialize(string)" are used
• Beginning with PHP 7.4: Serializable interface's methods are ignored, when "serialize(array)" and "unserialize():array" are defined (link)
• Beginning with PHP 8.1: To avoid that a deprecation notice is thrown "Implementing the Serializable interface without implementing serialize and unserialize methods is deprecated", "serialize(): string" and "unserialize(string)" where migrated to "serialize(array)" and "unserialize():array"

[fbett]

I'm sorry for all the commits, but it was much harder to get a successfully TRAVIS PHP 8.1 result as thought at the beginning. PHP CS FIXER on version 2 has problem using PHP 8.1: The result differs when running using PHP 8.0 or lower:

Runtime: PHP 8.0.15 Loaded config default from ".php-cs-fixer.php". ......F...... Legend: ?-unknown, I-invalid file syntax (file ignored), S-skipped (cached or empty file), .-no changes, F-fixed, E-error 1) phpFinTS/lib/Fhp/MT940/MT940.php (unary_operator_spaces)

Runtime: PHP 8.1.2 Loaded config default from ".php-cs-fixer.php". ......F...... Legend: ?-unknown, I-invalid file syntax (file ignored), S-skipped (cached or empty file), .-no changes, F-fixed, E-error 1) phpFinTS/lib/Fhp/MT940/MT940.php (function_typehint_space)

Using PHP 8.0 or lower, PHP CS FIXER will remove the spaces between the reference parameter sign and the parameter name, in line 197 of phpFinTS/lib/Fhp/MT940/MT940.php: protected function extractStructuredDataFromRemittanceLines($descriptionLines, string &$gvc, array &$rawLines, array $transaction): array Using PHP 8.1, PHP CS FIXER will add spaces: protected function extractStructuredDataFromRemittanceLines($descriptionLines, string & $gvc, array & $rawLines, array $transaction): array

I tested also a small upgrade to V2.19.x, but the problem also exists there. I made a migration to V3 using the migration guide. The only downside from my view is:

• When using the PHP CS FIXER, PHP 7.4 is now the minimum: Travis is already configured to use a PHP version from 7.4
• When this pull request is merged, all files within this project should be checked once by PHP CS FIXER to get over the small differences (like the "public" prefix for constants, see lib/Fhp/MT940/MT940.php in the last commit)

[fbett]

I don't understand, what was the loop that this fixes?

Example:

• DialogInitialization::unserialize called DialogInitialization::__unserialize
• DialogInitialization::__unserialize called parent::unserialize (BaseAction::unserialize)
• BaseAction::unserialize called $this-> unserialize (DialogInitialization::unserialize) <-- This should not happen (loop)

[Philipp91]

• BaseAction::unserialize called $this-> unserialize (DialogInitialization::unserialize)

But this doesn't happen? BaseAction::unserialize calls some __unserialize function (be it on $this or self) and not another (non-magic) unserialize.

[fbett]

• BaseAction::unserialize called $this-> unserialize (DialogInitialization::unserialize)

But this doesn't happen? BaseAction::unserialize calls some __unserialize function (be it on $this or self) and not another (non-magic) unserialize.

Oh, yes, the last call was wrong.

• DialogInitialization::unserialize called DialogInitialization::__unserialize
• DialogInitialization::__unserialize called parent::unserialize (BaseAction::unserialize)
• BaseAction::unserialize called $this->unserialize (DialogInitialization::unserialize) <-- Loop

[Philipp91]

Oh right, makes sense. Thanks for the explanation.