search

nemiah / phpFinTS

PHP library to communicate with FinTS/HBCI servers
MIT License
131 stars 40 forks source link

fix #354: Sammelüberweisung #366

Closed carli2 closed 2 months ago

carli2 commented 2 years ago

We implemented the feature and would like to get it mainstream

https://launix.de/launix/launix-unterstuetzt-die-freie-fints-schnittstelle-phpfints/

carli2 commented 2 years ago

Copyright marks are fine with MIT. Every author gains copyright by creating a piece of work automatically. By publishing it, the code additionally gets licensed under MIT, so everyone can use it.

We wrote the copyright notice this way because the author differs from the copyright holder.

LaunixPeter commented 2 years ago

Thanks for the review. I will look into it and make changes tomorrow.

Philipp91 commented 2 years ago

To fix the Travis failures, see here.

nemiah commented 2 years ago

Will anyone fix this one?

carli2 commented 1 year ago

As far as we can see, Travis CI yields some false positives. Correct me if I'm wrong.

roben commented 1 year ago

Do I undestand it correctly that even with BtchBookg set to false I would still be allowed to submit multiple transfers with a single TAN while having each transfer listed as a single transaction by the bank? It would be awesome to have this added to the library.

carli2 commented 1 year ago

Do I undestand it correctly that even with BtchBookg set to false I would still be allowed to submit multiple transfers with a single TAN while having each transfer listed as a single transaction by the bank? It would be awesome to have this added to the library.

No. But you can encode multiple transfers in a single SEPA file and submit this file with one single TAN which basically yields the same result.

We already forked the library to have this feature in our software.

roben commented 1 year ago

But you can encode multiple transfers in a single SEPA file and submit this file with one single TAN which basically yields the same result.

That's what I meant. Are those transactions then listed by the bank individually or all together as a single "Sammelauftrag"? As I understood it, the flag BtchBookg governs this behavior (https://www.sparkasse-landsberg.de/content/dam/myif/spk-landsberg-diessen/work/dokumente/pdf-ll/SEPA%20FAQs.pdf) but I did not find any information if multiple transfers in a single XML file are possible at all with BtchBookg = false

lukas-staab commented 1 year ago

As far as we can see, Travis CI yields some false positives. Correct me if I'm wrong.

I dont think so. I encountered this issue before. Because this repo has no composer.lock file (because of the different php versions), you have to be carefull to delete your own lock file, then do a composer update / install and only then the composer cs-fix.

If this is the problem, we should add this to the linked passage

To fix the Travis failures, see here.

carli2 commented 2 months ago

Is this branch merged not into nemiah:master or not?

nemiah commented 2 months ago

Hi, I did not merge because I don't know in which state this PR is and I don't have the time to find out. If you still want, please make a new PR for the current version.

carli2 commented 2 months ago

The feature was complete. It were just the automated test cases that failed with a thing completely unrelated to the patch.