search

nemiah / phpFinTS

PHP library to communicate with FinTS/HBCI servers
MIT License
131 stars 40 forks source link

adding composer.lock to git #387

Closed lukas-staab closed 2 years ago

lukas-staab commented 2 years ago

Adding composer.lock to git repo, as discussed in #385 (https://github.com/nemiah/phpFinTS/pull/385#issuecomment-1213072667)

nemiah commented 2 years ago

Can the Travis error be fixed?

lukas-staab commented 2 years ago

yes, i wanted to wait until the other PR was done to rebase this one

lukas-staab commented 2 years ago

ah damn, it is more complex that I initially thought. The composer lock has locked down to php8.1 dependencies. Now the 8.1 check works, the other 2 are not. I see 2 possible solutions: run - in older php versions - a composer update in travis. We could also do it in the newer version - but then the composer.lock itself would be a bit meaningless. I tend to withdraw this PR and add a hint to the contribution guidelines instead, not only to run composer cs-fix but also composer update so local lock files do not get outdated. Any other opinions @nemiah @Philipp91 ?

nemiah commented 2 years ago

I usually opt for the simpler solution. Adding composer update to the Readme Contribute-section is fine by me :relaxed:

lukas-staab commented 2 years ago

fine by me as well. Then this PR can be closed imo