search

nemiah / phpFinTS

PHP library to communicate with FinTS/HBCI servers
MIT License
130 stars 42 forks source link

SEPA direct debit #397

Closed timrasche closed 3 months ago

timrasche commented 1 year ago

Is it possible to force the paramater "einzelbuchungGewuenscht" on Action "SendSEPADirectDebit" to reliable value of "true"?

Philipp91 commented 1 year ago

Not today. In fact, it's either null by default or false in this special case, which looks a little suspicious to me.

I wonder if instead of

if (!$useSingleDirectDebit) {
    if ($hidxes->getParameter()->einzelbuchungErlaubt) {
        $hkdxe->einzelbuchungGewuenscht = false;
    }
}

we perhaps want

if ($hidxes->getParameter()->einzelbuchungErlaubt) {
    $hkdxe->einzelbuchungGewuenscht = $useSingleDirectDebit;
}
timrasche commented 1 year ago

@Philipp91 Thanks for review, and i agree. Think need exactly this.

Philipp91 commented 1 year ago

You can patch it in and try it out, send a PR if it worked.

ampaze commented 1 year ago

Just a heads up, $useSingleDirectDebit is only the type of request that is send to the bank (HIDME or HKDME). It has nothing to do with einzelbuchungGewuenscht except that einzelbuchungGewuenscht is only available for HKDME.

timrasche commented 6 months ago

hm ok, can we bring up this topic? I cant see any line of code in the examples or other parts to use this value "einzelbuchungGewuenscht" in combination with multiple sepa direct debits or transfers. Its mandatory on our software to list account statements as single lines and not in a collective way.

ampaze commented 6 months ago

Just setting it to truewould potentially change functionality of software using this lib, including ours.

Options are: