search

nemith / netconf

NETCONF implementation in Go.
Other
29 stars 7 forks source link

Notifications support #52

Closed GiacomoCortesi closed 1 year ago

GiacomoCortesi commented 1 year ago

implementation of netconf notifications as per proposal in https://github.com/nemith/netconf/issues/51

I've added a couple of TODOs that we may or may not want to address.

Filter parameter implementation may be out of scope and deserve its own PR, what plans have you for it?

About checks on capabilities I'm not sure you actually want to address them here, at least I don't see other places where you take capabilities into account.

GiacomoCortesi commented 1 year ago

Looks good.

Couple minor nits and it seems like you may need to rebase on top of master (there was some changes with how recv() works.

I rebased and applied fixes as per comments