nemoarchive / analytics

Repository for the NeMO Analytics project.
MIT License
1 stars 0 forks source link

can we control size and coloring of points in a standard dynamic scatter plot? #122

Closed carlocolantuoni closed 4 years ago

carlocolantuoni commented 4 years ago

this can be an additional element in the display parameters within the view curation

adkinsrs commented 4 years ago
Screen Shot 2020-07-29 at 10 23 32 AM

The slider corresponds to marker sizes 1-15 with 3 being the default size, which is what gEAR currently shows. Also in the Marker Size label, it now reads "Marker Size (right is larger)" instead of "Marker Size (1-15)". Furthermore, this slider only appears if plot type "scatter" is chosen.

carlocolantuoni commented 4 years ago

This looks great! Let me kno wen/if i can try it out on my NeMO dat sets. Thanks! Carlo

On Wed, Jul 29, 2020, 10:27 Shaun Adkins notifications@github.com wrote:

[image: Screen Shot 2020-07-29 at 10 23 32 AM] https://user-images.githubusercontent.com/5665914/88812358-a0643a00-d185-11ea-95c1-1e628ba345ae.png

The slider corresponds to marker sizes 1-15 with 3 being the default size, which is what gEAR currently shows. Also in the Marker Size label, it now reads "Marker Size (right is larger)" instead of "Marker Size (1-15)"

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/nemoarchive/analytics/issues/122#issuecomment-665697728, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH7KC7TRNGJF2IU35HC3TQ3R6AWWBANCNFSM4PGZ7O6A .

jorvis commented 4 years ago

This is great Shaun!

carlocolantuoni commented 4 years ago

is it live on devel now?

On Wed, Jul 29, 2020, 18:05 Joshua Orvis notifications@github.com wrote:

This is great Shaun!

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/nemoarchive/analytics/issues/122#issuecomment-665954500, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH7KC7XYGNAG2GU45HEL2BTR6CMMLANCNFSM4PGZ7O6A .

jorvis commented 4 years ago

Nope. Going to create a new devel since so much has been uploaded to production. Will do it tonight since it requires about 20 min of downtime for production

On Wed, Jul 29, 2020, 7:00 PM Carlo Colantuoni notifications@github.com wrote:

is it live on devel now?

On Wed, Jul 29, 2020, 18:05 Joshua Orvis notifications@github.com wrote:

This is great Shaun!

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub < https://github.com/nemoarchive/analytics/issues/122#issuecomment-665954500 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AH7KC7XYGNAG2GU45HEL2BTR6CMMLANCNFSM4PGZ7O6A

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nemoarchive/analytics/issues/122#issuecomment-665990803, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACQZE3B4F5GPN6IOALVMPTR6CZYXANCNFSM4PGZ7O6A .

carlocolantuoni commented 4 years ago

o gotcha, i hadnt put together all that. cool - thnx guys

On Wed, Jul 29, 2020, 20:04 Joshua Orvis notifications@github.com wrote:

Nope. Going to create a new devel since so much has been uploaded to production. Will do it tonight since it requires about 20 min of downtime for production

On Wed, Jul 29, 2020, 7:00 PM Carlo Colantuoni notifications@github.com wrote:

is it live on devel now?

On Wed, Jul 29, 2020, 18:05 Joshua Orvis notifications@github.com wrote:

This is great Shaun!

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <

https://github.com/nemoarchive/analytics/issues/122#issuecomment-665954500

, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AH7KC7XYGNAG2GU45HEL2BTR6CMMLANCNFSM4PGZ7O6A

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/nemoarchive/analytics/issues/122#issuecomment-665990803 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AACQZE3B4F5GPN6IOALVMPTR6CZYXANCNFSM4PGZ7O6A

.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/nemoarchive/analytics/issues/122#issuecomment-665992406, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH7KC7WC5AUD6BSQK3RHNCTR6C2JFANCNFSM4PGZ7O6A .

carlocolantuoni commented 4 years ago

@adkinsrs in the devel version where u have implemented the plot symbol size slider: it looks great! but it doesnt save the change.

adkinsrs commented 4 years ago

Deployed this to devel.umgear.org

adkinsrs commented 4 years ago

Noted. I'll look into that. Completely forgot to look into the "save display" functionality

adkinsrs commented 4 years ago

@carlocolantuoni I fixed the "save" issue, and the marker size shows up again when you want to re-edit the plot display. I forgot to pass the "marker_size" as a return value of the plotting API script

hertzron commented 4 years ago

can yo please send a screenshot of how it looks?

On Thu, Aug 6, 2020 at 1:17 PM Shaun Adkins notifications@github.com wrote:

@carlocolantuoni https://github.com/carlocolantuoni I fixed the "save" issue, and the marker size shows up again when you want to re-edit the plot display. I forgot to pass the "marker_size" as a return value of the plotting API script

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nemoarchive/analytics/issues/122#issuecomment-670063425, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEFF5X423COG2WMDN6B5DHLR7LQSRANCNFSM4PGZ7O6A .

adkinsrs commented 4 years ago
Screen Shot 2020-08-06 at 1 27 08 PM Screen Shot 2020-08-06 at 1 27 59 PM

The default marker point size is 3, and here is a scatter plot (with tSNE axes) where I bumped it up to a size of 9. For reference, the selectable marker size range is 1 - 15

hertzron commented 4 years ago

This looks great!

Get Outlook for iOShttps://aka.ms/o0ukef


From: Shaun Adkins notifications@github.com Sent: Thursday, August 6, 2020 1:29:38 PM To: nemoarchive/analytics analytics@noreply.github.com Cc: hertzron hertzron@gmail.com; Comment comment@noreply.github.com Subject: Re: [nemoarchive/analytics] can we control size and coloring of points in a standard dynamic scatter plot? (#122)

[Screen Shot 2020-08-06 at 1 27 08 PM]https://user-images.githubusercontent.com/5665914/89562912-acd13e00-d7e8-11ea-9d95-ddb93aadab73.png

[Screen Shot 2020-08-06 at 1 27 59 PM]https://user-images.githubusercontent.com/5665914/89562931-b35fb580-d7e8-11ea-8c4a-caa0be3e0b6c.png

The default marker point size is 3, and here is a scatter plot where I bumped it up to 9. For reference, the selectable marker size range is 1 - 15

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/nemoarchive/analytics/issues/122#issuecomment-670070786, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEFF5X4BLOLE3TPZXDX3JCDR7LSAFANCNFSM4PGZ7O6A.

carlocolantuoni commented 4 years ago

nice shaun!

carlocolantuoni commented 4 years ago

@adkinsrs when i change the size of the points and the colors revert to defaults. i cant seem to change both the size and color without one of them reverting to defaults.

adkinsrs commented 4 years ago

Looking into it now. The UI code is in a Javascript framework (Vue.js) that I'm not overly familiar with, and there is probably something in there at the resets the colors when any plot parameter is changed (since I can add/remove facet groups and the same happens).

adkinsrs commented 4 years ago

Resolved the "colors and size reverting" issue as per a comment in #109. Closing the ticket.

carlocolantuoni commented 4 years ago

👍

On Tue, Aug 25, 2020 at 9:05 AM Shaun Adkins notifications@github.com wrote:

Closed #122 https://github.com/nemoarchive/analytics/issues/122.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nemoarchive/analytics/issues/122#event-3690001041, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH7KC7WG3NPXSUEKPRQBAP3SCOZKZANCNFSM4PGZ7O6A .

-- Carlo