search

nemoarchive / analytics

Repository for the NeMO Analytics project.
MIT License
1 stars 0 forks source link

Compare tool titles (I believe is also a request from reviewers) #147

Closed hertzron closed 3 years ago

hertzron commented 3 years ago

image

carlocolantuoni commented 3 years ago

hi all [un]related question about the compare tool - what is the max # observations it can handle? lately with scRNAseq data i've been getting a "too many observations" error carlo

On Sat, Jan 16, 2021 at 11:01 AM hertzron notifications@github.com wrote:

[image: image] https://user-images.githubusercontent.com/17456863/104816589-2cc4f080-57ea-11eb-8f28-a591356ac0a2.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nemoarchive/analytics/issues/147, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH7KC7UQAN4F4VZFAQKI7Q3S2GZ63ANCNFSM4WFLR2RA .

-- Carlo

adkinsrs commented 3 years ago

Dataset titles have been moved from the axes labels to the dataset title. The next step is to push the plot slightly down so that the title is not clipped at top. Will close ticket after I push a commit for that.

@carlocolantuoni I imagine that error is being propagated from Scanpy and I will try to look and get a specific number

adkinsrs commented 3 years ago

@carlocolantuoni Actually I was wrong.

The "too many observations" error happens when the "compare datasets" interface detects too many categorical columns in the observations table in the dataset. The maximum allowed is a hard-coded value in "get_condition_list.cgi" and is currently set to 5. Since the X- and Y- dropdown menus create an option for every combination of categorical observation group, having too many observations would really slow down the interface.

adkinsrs commented 3 years ago

Committed fix to the main ticket issue and it has been pushed to gear-devel