search

nemomobile / buteo-sync-plugin-caldav

12 stars 8 forks source link

Refactor Report class, move processing of ETags to NotebookSyncAgent #30

Closed sdrave closed 10 years ago

sdrave commented 10 years ago

Moving processETags into NotebookSyncAgent improves the separation between networking code and the synchronization algorithm. Moreover, this allows the reuse Report for additional REPORT requests.

Additionally, this commit moves code shared by the getAllEvents, getAllETags and multiGetEvents methods to sendCalendarQuery and sendRequest.

This pull request contains some of my work on improving support for synchronization with Owncloud. While not really necessary (it would suffice for me to make multiGetEvents public to be able to send an additional request), I believe the refactoring makes the code clearer and easier to understand. (It would also be convenient for me to have this in master as I would have to rework my fixes otherwise ..)

VDVsx commented 10 years ago

@blammit Please have a look also. Thx

blammit commented 10 years ago

The changes look good to me.