search

nemomobile / buteo-sync-plugins

1 stars 7 forks source link

[buteo-sync-plugins] Use QTEST_MAIN instead of own main.cpp file. #34

Closed VDVsx closed 10 years ago

VDVsx commented 10 years ago

Fix build and libs linking.

VDVsx commented 10 years ago

@blammit - Could you please take a look, better to check the commits separately. Thx.

rburchell commented 10 years ago

You probably want QTEST_GUILESS_MAIN, otherwise it'll involve the loading of a UI stack, which isn't there now (and won't be able to run headless)

VDVsx commented 10 years ago

Humm, doc says:

"If QT_GUI_LIB is defined, the application object will be a QApplication, otherwise it will be a QCoreApplication. If qmake is used and the configuration includes QT += gui, then QT_GUI_LIB will be defined automatically."

So looks fine for me, and also works fine, either as standalone or inside testrunner.

rburchell commented 10 years ago

I'd still prefer use of GUILESS_MAIN to be on the safe side.

VDVsx commented 10 years ago

Only in Qt5 it seems, so will do that change in separated commit when removing qt4 stuff from here to not mix up things more.

chriadam commented 10 years ago

The change of the runTestSuite signature seems unnecessary to me, but that makes no functional difference I guess. LGTM.