search

nemomobile / buteo-sync-plugins

1 stars 7 forks source link

[buteo-sync-plugins] Use remote_name instead of remote_id for OBEX #42

Closed chriadam closed 9 years ago

chriadam commented 9 years ago

Some Bluetooth OBEX sync profiles don't have a remote_id value set but only a remote_name. This commit ensures that the remote_name value is used as the target id when initialising the config for the profile, allowing it to be removed (as the cleanUp() function in the syncML library requires that value to be non-empty for remove).

chriadam commented 9 years ago

@blammit @hmallat @VDVsx

blammit commented 9 years ago

It's odd that the value is required for clean-up, but it seems fine to set the value on initialization in any case. LGTM

chriadam commented 9 years ago

https://github.com/nemomobile/buteo-syncml/blob/master/src/SyncAgent.cpp#L202 is the check. It uses the remote_id value for the changelog...

VDVsx commented 9 years ago

LGTM