Closed urjaman closed 9 years ago
Tested, WFM
Implemented some of the comments, made the null char hack unnecessary, reordered the parsing a bit... The diff looks quite horrible, i suggest just looking at the resulting code :), and yeah i know that too could still use more work.
I'll rebase this and squash the unnecessary hacks etc away later if requested, just showing my incremental progress for comments (and without losing the old comments).
Note: somebody noted that ctrl-backspace doesnt work, i might implement that at some point and other modifiers for enter and backspace.
ok i think thats it for now (until somebody comments something), ctrl-backspace and other similars implemented, cleaned up a bit.
LGTM. Could squash commits as you said, quite a lot of code churn on one method.
Russian keyboard handling still having small problems: e.g ctrl+z/c combinations don't do what they usually do while on desktop they work.
Thanks, I'll squash them (atleast the fixup ones) later when i get a moment.
Russian Ctrl-
Done. It was all quite in the same area so after some consideration I squashed all the stuff on this one function to one commit, ended up better than I expected for such a big squash.
This fixes #54 along with other improvements to behavior of hardware keyboards: