search

nemrutco / nova-global-filter

This package allows you to apply any of your existing Laravel Nova filters to your cards in Dashboards or Index and Detail view of your nova resources.
MIT License
39 stars 32 forks source link

Add empty value for filters #19

Closed xoco70 closed 4 years ago

xoco70 commented 4 years ago

Hi,

When including a filter, it comes with a default value I don't know if it is applied, nor how it choose it.

To compare with Nova behaviour, Nova always include an empty value. This allows to add / remove filter easily.

Here, when I choose a filter, I cannot remove it. Even with 'reset', it reset to the first value of the list.

There should have a -- first entry.

MuzafferDede commented 4 years ago

Should be fixed by v1.0.5

xoco70 commented 4 years ago

Yep, it worked. But now, ->inline() is broken! ^^

xoco70 commented 4 years ago

and weird thing, I have 4 filters, but I can only see 3

xoco70 commented 4 years ago

oooh, The fourth one is below the cards. I'll make you a screenshot

xoco70 commented 4 years ago

Screenshot from 2020-07-30 17-24-16

Here the last field is : "Jusqu'au" in blue

MuzafferDede commented 4 years ago

For some reason, branches are mixed up. Just fixed by v1.1.0