search

nemtsov / node-bunyan-logentries

Bunyan logger stream for Logentries
MIT License
9 stars 9 forks source link

minLevel not being set on le_node #4

Closed chazmo03 closed 8 years ago

chazmo03 commented 8 years ago

I'm seeing an issue I haven't seen before after almost a year of using this package. It looks like le_node is filtering out debug and trace messages and there's no place on the API to configure this. When using bunyan, I think the expected usage would be to configure the min level in bunyan and then have le_node just pipe everything through. This is using 0.2.1 of le_node, which seems to set minLevel to 1 instead of 0. I hacked in logentriesStream._logger.level('trace'); to work around this, but should this library update to a newer version of le_node?

nemtsov commented 8 years ago

Sure. Are you interested in doing a PR?

chazmo03 commented 8 years ago

Sure, I'll try to pull it together in the next few days. To just upgrade to the latest le_node? Do you happen to know where version 0.2.1 of le_node came from?

nemtsov commented 8 years ago

Let's start with the version. But please propose more changes if needed. I think that's the version that was available at the time I released this. On Fri, Oct 23, 2015 at 8:55 PM Charles Augello notifications@github.com wrote:

Sure, I'll try to pull it together in the next few days. To just upgrade to the latest le_node? Do you happen to know where version 0.2.1 of le_node came from?

— Reply to this email directly or view it on GitHub https://github.com/nemtsov/node-bunyan-logentries/issues/4#issuecomment-150729797 .

chazmo03 commented 8 years ago

It looks like the newer version of le_node is designed (and documented) to be used quite easily directly with bunyan. I think that's the better option so I don't think there's much use for this module.