nemuTUI / nemu

Ncurses UI for QEMU
BSD 2-Clause "Simplified" License
317 stars 22 forks source link

Packaging for Alpine #116

Closed txgk closed 2 years ago

txgk commented 2 years ago

Hi, I put out a package of nemu to Alpine's repositories and I have a little feedback regarding the nemu build process in that environment.

  1. GCC spits out a couple of warnings related to SHA256 deprecation in OpenSSL 3.0. I understand that this is not a serious problem, I just hope that there is a way to turn off just these warnings or to tell OpenSSL don't scold on SHA256 usage :)

  2. CMake doesn't install bash completion even after I've created $pkgdir/usr/share/bash-completion/completions directory ($pkgdir is a prefix for the package). I guess it checks the system directory and not the package directory.

In this MR I removed check for the presence of a bash completions directory to make CMake always install completions. Also I added commit with a mention of the nemu package in Alpine's repos.

Thanks for this tool, comrades ;)

0x501D commented 2 years ago

Thanks for the patch and packaging!

OpenSSL 3.0 warnings will be fixed soon (I'll create issue). For now you can build nemu without remote control feature: NM_WITH_REMOTE. It requires openssl.