nenadV91 / devcon-token-list

0 stars 0 forks source link

Improve script: Feedback on first version #1

Open anxolin opened 1 year ago

anxolin commented 1 year ago

Okay @Nenad Vracar looks good enought to make a first version list.

However, we will need to evolve this script a bit.

1) This list is used as filter and to find the addresses, and to add the tokens. I find is a pragmatic solution, however we will need to evolve it. We cannot assume all tokens will be in that list. It should be more dynamic. https://github.com/nenadV91/devcon-token-list/blob/main/script.js#L22

2) We can add more comments, and simpler var names. There's a lot of single letter vars 3) We can add some README with instructions on how to use it 4) We can use yargs or similar to add parameters 5) We need also the tokens for Gnosis Chain, for that I already shard one coingecko endpoint that will help you. This endpoint, might help you also with (1)

6) Sorting by market cap might not be enough in some cases, maybe we can have some other criteria in the future. Like at least this market cap, and we sort by 24h volume

anxolin commented 1 year ago

https://cowservices.slack.com/archives/C0361CDG8GP/p1664978300574269

nenad commented 1 year ago

You have tagged the wrong Nenad. I think you are looking for @nenadV91.